Skip to content

[SPARK-14975][ML] Fixed GBTClassifier to predict probability per training instance and fixed interfaces #16441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
imatiach-msft wants to merge 20 commits into from
Closed

[SPARK-14975][ML] Fixed GBTClassifier to predict probability per training instance and fixed interfaces #16441

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
08831e7
[SPARK-14975][ML][WIP] Fixed GBTClassifier to predict probability per…
imatiach-msft Dec 30, 2016
e73b60f
Fixed scala style empty line
imatiach-msft Dec 30, 2016
d29b70d
Fixed binary compatibility tests
imatiach-msft Dec 30, 2016
d4afdd0
Fixing GBT classifier based on comments
imatiach-msft Jan 3, 2017
62702c8
Fixing probabilities calculated from raw scores
imatiach-msft Jan 5, 2017
27882b3
fixed scala style, multiplied raw prediction value by 2 in prob estimate
imatiach-msft Jan 5, 2017
8698d16
Updating based on code review, including code cleanup and adding bett…
imatiach-msft Jan 6, 2017
aaf1b06
Adding back constructor but making it private
imatiach-msft Jan 6, 2017
bafab79
updates to GBTClassifier based on comments
imatiach-msft Jan 10, 2017
2a6dea4
minor fixes to scala style
imatiach-msft Jan 10, 2017
52c5115
Fixing more scala style
imatiach-msft Jan 10, 2017
609a1b0
Using getOldLossType as per comments
imatiach-msft Jan 10, 2017
a28afe6
Added more tests for thresholds, fixed minor bug in predict to use th…
imatiach-msft Jan 10, 2017
9d5bb9b
Updated based on newest comments
imatiach-msft Jan 10, 2017
89965f5
missed one arg
imatiach-msft Jan 10, 2017
cacbbc1
Moving arg to its own line
imatiach-msft Jan 10, 2017
7396dac
Updated based on latest comments - moved classifier loss trait, updat…
imatiach-msft Jan 11, 2017
f2e041d
Fixed up minor comments
imatiach-msft Jan 11, 2017
1abfee0
Updated based on comments from jkbradley
imatiach-msft Jan 18, 2017
818de81
Fixing build issues - need to keep numClasses in model
imatiach-msft Jan 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
minor fixes to scala style
  • Loading branch information
@imatiach-msft
imatiach-msft committed Jan 18, 2017
commit 2a6dea431aee1de17610149dbb19fb7f8d6a8b4a
3 changes: 2 additions & 1 deletion mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ package org.apache.spark.ml.classification
import com.github.fommil.netlib.BLAS.{getInstance => blas}
import org.json4s.{DefaultFormats, JObject}
import org.json4s.JsonDSL._

import org.apache.spark.annotation.Since
import org.apache.spark.internal.Logging
import org.apache.spark.ml.feature.LabeledPoint
Expand All @@ -31,7 +32,7 @@ import org.apache.spark.ml.tree.impl.GradientBoostedTrees
import org.apache.spark.ml.util._
import org.apache.spark.ml.util.DefaultParamsReader.Metadata
import org.apache.spark.mllib.tree.configuration.{Algo => OldAlgo}
import org.apache.spark.mllib.tree.loss.{ClassificationLoss, LogLoss}
import org.apache.spark.mllib.tree.loss.LogLoss
import org.apache.spark.mllib.tree.model.{GradientBoostedTreesModel => OldGBTModel}
import org.apache.spark.rdd.RDD
import org.apache.spark.sql.{DataFrame, Dataset, Row}
Expand Down