[SPARK-17237][SPARK-17458][SQL][Backport-2.0] Preserve aliases that are given for pivot aggregations #16565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #71281 has finished for PR 16565 at commit
|
Member
|
Could you change the PR title to |
Member
Author
|
okay! I'm now looking into the test failure, so just a sec, thanks |
maropu
changed the title
|
Test build #71290 has finished for PR 16565 at commit
|
Member
|
I checked the change history. Actually, you also backported #15111. Could you please update your PR description and PR title? |
Member
|
LGTM except one comment |
Member
Author
|
@gatorsmile oh, I see. Is it okay to mix this pr with the fix of #15111? Would it be better to backport #15111 first then, backport this? |
Member
Author
|
@gatorsmile ping |
Member
|
I think it is fine to do it together. Basically, your PR is to fix the bug of #15111 |
Member
Author
|
okay! I'll update them |
maropu
changed the title
maropu
changed the title
Member
Author
|
@gatorsmile How about this fix? plz check this again? |
asfgit
pushed a commit
that referenced
this pull request
Jan 15, 2017
…re given for pivot aggregations ## What changes were proposed in this pull request? This pr is to preserve aliases that are given for pivot aggregations to solve the issue reported in `SPARK-17237`. This pivoting adds backticks (e.g. 3_count(\`c\`)) in column names and, in some cases, thes causes analysis exceptions like; ``` scala> val df = Seq((2, 3, 4), (3, 4, 5)).toDF("a", "x", "y") scala> df.groupBy("a").pivot("x").agg(count("y"), avg("y")).na.fill(0) org.apache.spark.sql.AnalysisException: syntax error in attribute name: `3_count(`y`)`; at org.apache.spark.sql.catalyst.analysis.UnresolvedAttribute$.e$1(unresolved.scala:134) at org.apache.spark.sql.catalyst.analysis.UnresolvedAttribute$.parseAttributeName(unresolved.scala:144) ... ``` So, this pr also removes these backticks from column names. ## How was this patch tested? Added a test in `DataFrameAggregateSuite`. Author: Takeshi YAMAMURO <[email protected]> Closes #16565 from maropu/SPARK-17237-3.
Member
|
Thanks! Merging to 2.0 Could you please close it? |
Member
Author
|
Okay and thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr is to preserve aliases that are given for pivot aggregations to solve the issue reported in
SPARK-17237. This pivoting adds backticks (e.g. 3_count(`c`)) in column names and, in some cases,thes causes analysis exceptions like;
So, this pr also removes these backticks from column names.
How was this patch tested?
Added a test in
DataFrameAggregateSuite.