Skip to content

[SPARK-19218][SQL] Fix SET command to show a result correctly and in a sorted order #16579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dongjoon-hyun wants to merge 9 commits into from
Closed

[SPARK-19218][SQL] Fix SET command to show a result correctly and in a sorted order #16579

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c182c7d
[SPARK-19218][SQL] SET command should show a sorted result
dongjoon-hyun Jan 13, 2017
2ed6d87
Address comments.
dongjoon-hyun Jan 13, 2017
fa4914b
Revert to the approved commit and remove `set -v` test case to avoid …
dongjoon-hyun Jan 21, 2017
fb578d1
Add fix and recover `SET -v` test case.
dongjoon-hyun Jan 22, 2017
0214fad
Address comments
dongjoon-hyun Jan 22, 2017
528b0fd
Use Option.
dongjoon-hyun Jan 23, 2017
387ab59
Add `unregister` and use it.
dongjoon-hyun Jan 23, 2017
7061cd9
Remove redundant one.
dongjoon-hyun Jan 23, 2017
7879201
Add a missing clear() while splitting the testcases
dongjoon-hyun Jan 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use Option.
  • Loading branch information
@dongjoon-hyun
dongjoon-hyun committed Jan 23, 2017
commit 528b0fd1bd8a685f14d708d1a47570924835e569
2 changes: 1 addition & 1 deletion sql/core/src/main/scala/org/apache/spark/sql/execution/command/SetCommand.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ case class SetCommand(kv: Option[(String, Option[String])]) extends RunnableComm
val runFunc = (sparkSession: SparkSession) => {
sparkSession.sessionState.conf.getAllDefinedConfs.sorted.map {
case (key, defaultValue, doc) =>
Row(key, if (defaultValue == null) "<undefined>" else defaultValue, doc)
Row(key, Option(defaultValue).getOrElse("<undefined>"), doc)
}
}
val schema = StructType(
Expand Down