Skip to content

[SPARK-19270][ML] Add summary table to GLM summary #16630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
actuaryzhang wants to merge 21 commits into from
Closed

[SPARK-19270][ML] Add summary table to GLM summary #16630

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
19b8de4
Start working on summary table
actuaryzhang Jan 13, 2017
93139b9
convert result to dataframe
actuaryzhang Jan 17, 2017
0b50f34
Add test
actuaryzhang Jan 18, 2017
af2dbea
minor cleanup
actuaryzhang Jan 18, 2017
e2ac2d4
clean up test
actuaryzhang Jan 18, 2017
eec31b4
clean up imports
actuaryzhang Jan 18, 2017
602c3bd
fix style issues
actuaryzhang Jan 25, 2017
6882be4
change default name to use feature colname
actuaryzhang Feb 14, 2017
8405501
glmTable
actuaryzhang Feb 14, 2017
10f0f9b
update R glm wrapper to use summaryTable
actuaryzhang Feb 17, 2017
3d72cf5
clean up test
actuaryzhang Feb 17, 2017
07a6784
fix issue in R wrapper
actuaryzhang Feb 17, 2017
1c1d3e6
sort import
actuaryzhang Feb 24, 2017
a16cbee
use 2D array for summary table
actuaryzhang Jul 17, 2017
640d564
fix import
actuaryzhang Jul 17, 2017
57f1e5c
remove intercept
actuaryzhang Jul 17, 2017
167af01
simplify show method
actuaryzhang Jul 19, 2017
174fc49
fix align issue
actuaryzhang Jul 19, 2017
be11106
Refactor GLR summary toString.
yanboliang Jul 26, 2017
adb3a74
Merge branch 'yanboliang-glmTable' into glmTable
actuaryzhang Jul 26, 2017
7281b77
fix style
actuaryzhang Jul 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix style issues
  • Loading branch information
@actuaryzhang
actuaryzhang committed Jul 13, 2017
commit 602c3bd91ff481da6fb37743d1c007305b3d47a5
9 changes: 4 additions & 5 deletions mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1478,10 +1478,9 @@ class GeneralizedLinearRegressionTrainingSummary private[regression] (
}

/**
* Summary table with feature name, coefficient, standard error,
* tValue and pValue.
*
*/
* Summary table with feature name, coefficient, standard error,
* tValue and pValue.
*/
@Since("2.2.0")
lazy val summaryTable: DataFrame = {
if (isNormalSolver) {
Expand All @@ -1491,7 +1490,7 @@ class GeneralizedLinearRegressionTrainingSummary private[regression] (
if (model.getFitIntercept) {
featureNames = featureNames :+ "Intercept"
coefficients = coefficients :+ model.intercept
// reorder so that intercept comes first
// Reorder so that intercept comes first
idx = (coefficients.length - 1) +: idx
}
val result = for (i <- idx.toSeq) yield
Expand Down