Skip to content

[SPARK-18016][SQL][CATALYST] Code Generation: Constant Pool Limit #16648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bdrillard wants to merge 6 commits into from
Closed

[SPARK-18016][SQL][CATALYST] Code Generation: Constant Pool Limit #16648

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
240d5a3
adding initial class splitting
Jan 11, 2017
75052c2
class_splitting mutable projections mutable state fix
Mar 30, 2017
0128e1e
class_splitting increasing memory during tests, fixing accessor refer…
Apr 6, 2017
fd9524d
class_splitting fixup on line length
May 11, 2017
8ce47fa
class_splitting import ordering and catalyst memory increase
May 11, 2017
5a4a39c
[class_splitting] adding more explicit mutableStateArray comments
May 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
class_splitting increasing memory during tests, fixing accessor refer… 
…ences
  • Loading branch information
ALeksander Eskilson committed May 16, 2017
commit 0128e1eba5a7ad4ea37808006e125a8f462de32e
4 changes: 2 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2005,7 +2005,7 @@
<include>**/*Suite.java</include>
</includes>
<reportsDirectory>${project.build.directory}/surefire-reports</reportsDirectory>
<argLine>-Xmx3g -Xss4096k -XX:ReservedCodeCacheSize=${CodeCacheSize}</argLine>
<argLine>-Xmx4g -Xss4096k -XX:ReservedCodeCacheSize=${CodeCacheSize}</argLine>
<environmentVariables>
<!--
Setting SPARK_DIST_CLASSPATH is a simple way to make sure any child processes
Expand Down Expand Up @@ -2054,7 +2054,7 @@
<reportsDirectory>${project.build.directory}/surefire-reports</reportsDirectory>
<junitxml>.</junitxml>
<filereports>SparkTestSuite.txt</filereports>
<argLine>-ea -Xmx3g -XX:ReservedCodeCacheSize=${CodeCacheSize}</argLine>
<argLine>-ea -Xmx4g -XX:ReservedCodeCacheSize=${CodeCacheSize}</argLine>
<stderr/>
<environmentVariables>
<!--
Expand Down
2 changes: 1 addition & 1 deletion sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ case class NewInstance(
ctx.addMutableState(javaType, ev.value, s"${ev.value} = ${ctx.defaultValue(javaType)};")

val constructorCall = outer.map { gen =>
s"$valueAccessor.new ${cls.getSimpleName}($argString)"
s"${gen.value}.new ${cls.getSimpleName}($argString)"
}.getOrElse {
s"new $className($argString)"
}
Expand Down
2 changes: 1 addition & 1 deletion ...catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,7 @@ case class StringTranslate(srcExpr: Expression, matchingExpr: Expression, replac

nullSafeCodeGen(ctx, ev, (src, matching, replace) => {
val check = if (matchingExpr.foldable && replaceExpr.foldable) {
s"$termDict == null"
s"$termDictAccessor == null"
} else {
s"!$matching.equals($termLastMatchingAccessor) " +
s"|| !$replace.equals($termLastReplaceAccessor)"
Expand Down