Skip to content

[SPARK-19309][SQL] disable common subexpression elimination for conditional expressions #16659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cloud-fan wants to merge 4 commits into from
Closed

[SPARK-19309][SQL] disable common subexpression elimination for conditional expressions #16659

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
45608b1
disable common subexpression elimination for conditional expressions
cloud-fan Jan 20, 2017
cda9723
address comments
cloud-fan Jan 21, 2017
e7d928c
improve
cloud-fan Jan 21, 2017
0753ee6
address comments
cloud-fan Jan 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
address comments
  • Loading branch information
@cloud-fan
cloud-fan committed Jan 23, 2017
commit 0753ee6da4d5698d3a30d89e60ec45aca9e18f35
3 changes: 2 additions & 1 deletion ...lyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/EquivalentExpressions.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,8 @@ class EquivalentExpressions {
def childrenToRecurse: Seq[Expression] = expr match {
case _: CodegenFallback => Nil
case i: If => i.predicate :: Nil
case c: CaseWhenBase => c.children.head :: Nil
// `CaseWhen` implements `CodegenFallback`, we only need to handle `CaseWhenCodegen` here.
case c: CaseWhenCodegen => c.children.head :: Nil
case c: Coalesce => c.children.head :: Nil
case other => other.children
}
Expand Down