Skip to content

[SPARK-19311][SQL] fix UDT hierarchy issue #16660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gmoehler wants to merge 7 commits into from
Closed

[SPARK-19311][SQL] fix UDT hierarchy issue #16660

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7ea9aa6
fix UDT hierarchy issue https://issues.apache.org/jira/browse/SPARK-1…
Jan 20, 2017
fad9f0e
add test case for SPARK-19311. Test case still fails - cause from els…
Jan 23, 2017
fb261d7
minor corrections of unit test case
Jan 23, 2017
6b6b773
re-organize imports to satisfy Scalastyle checks
Jan 23, 2017
4ae0555
re-organize imports to satisfy Scalastyle checks & add correct indend…
Jan 23, 2017
7aed9a4
worked in comments regarding style & not required overrides
Jan 24, 2017
6c16760
remove unnecessary toString() method
Jan 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix UDT hierarchy issue https://issues.apache.org/jira/browse/SPARK-1… 
…9311
  • Loading branch information
gmoehler committed Jan 20, 2017
commit 7ea9aa636f430a30b8d83ed2dda954fd06347d79
8 changes: 6 additions & 2 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/types/UserDefinedType.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,12 @@ abstract class UserDefinedType[UserType >: Null] extends DataType with Serializa
*/
override private[spark] def asNullable: UserDefinedType[UserType] = this

override private[sql] def acceptsType(dataType: DataType) =
this.getClass == dataType.getClass
override private[sql] def acceptsType(dataType: DataType) = dataType match {
case other: UserDefinedType[_] =>
this.getClass == other.getClass ||
this.userClass.isAssignableFrom(other.userClass)
case _ => false
}

override def sql: String = sqlType.sql

Expand Down