Skip to content

[SPARK-18120 ][SQL] Call QueryExecutionListener callback methods for … #16664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
salilsurendran wants to merge 5 commits into from
Closed

[SPARK-18120 ][SQL] Call QueryExecutionListener callback methods for … #16664

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
751ded0
[SPARK-18120 ][SQL] Call QueryExecutionListener callback methods for …
Jan 20, 2017
b0392ed
Merge branch 'master' into SPARK-18120
salilsurendran Jan 30, 2017
752125a
Fixing code review comments
Jan 30, 2017
ecf9f34
Committing to fix code review issues.
Feb 3, 2017
a0c7c22
Committing to fix code review comments
Feb 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'master' into SPARK-18120
  • Loading branch information
@salilsurendran
salilsurendran authored Jan 30, 2017
commit b0392ed5a8ebda9ace514b10bc383b9ffa47ac4c
8 changes: 8 additions & 0 deletions sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -660,13 +660,21 @@ object SQLConf {
.booleanConf
.createWithDefault(false)


val QUERY_EXECUTION_LISTENERS =
Copy link
Member

@gatorsmile gatorsmile Feb 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can put it into StaticSQLConf

ConfigBuilder("spark.sql.queryExecutionListeners")
.doc("QueryExecutionListeners to be attached to the SparkSession")
Copy link
Member

@gatorsmile gatorsmile Feb 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you improve this line? Add what you wrote in the sql-programming-guide.md?

Copy link
Author

@salilsurendran salilsurendran Feb 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case I updated the doc to read "A comma-separated list of classes that implement QueryExecutionListener that will be attached to the SparkSession". I could attach the whole line I put in sql-programming-guide.md but it will make it look out of place compared to the docs for other properties in the same class.

Copy link
Member

@gatorsmile gatorsmile Feb 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not have a separate document for the Spark SQL configuration. We expect users to do it using the command set -v. This command will output the contents of doc.

.stringConf
.toSequence
.createWithDefault(Nil)

val SESSION_LOCAL_TIMEZONE =
SQLConfigBuilder("spark.sql.session.timeZone")
.doc("""The ID of session local timezone, e.g. "GMT", "America/Los_Angeles", etc.""")
.stringConf
.createWithDefault(TimeZone.getDefault().getID())


Copy link
Member

@gatorsmile gatorsmile Feb 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Please remove this empty line

object Deprecated {
val MAPRED_REDUCE_TASKS = "mapred.reduce.tasks"
}
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.