Skip to content

[SPARK-19591][ML][MLlib] Add sample weights to decision trees #16722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sethah wants to merge 7 commits into from
Closed

[SPARK-19591][ML][MLlib] Add sample weights to decision trees #16722

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2d86cea
add weights to dt
sethah Jan 27, 2017
7dc1437
dt tests passing
sethah Jan 27, 2017
2729a63
typo
sethah Jan 28, 2017
2112720
mima
sethah Jan 28, 2017
159c5a6
test failure
sethah Jan 31, 2017
1db8494
address some review
sethah Feb 1, 2017
48b1258
address review
sethah Feb 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test failure
  • Loading branch information
@sethah
sethah committed Jan 31, 2017
commit 159c5a61758453fb47ceeb2ca6b2c3f7418ce5fd
4 changes: 2 additions & 2 deletions mllib/src/test/scala/org/apache/spark/ml/util/MLTestingUtils.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,10 +263,10 @@ object MLTestingUtils extends SparkFunSuite {
modelEquals: (M, M) => Unit,
outlierRatio: Int): Unit = {
import data.sqlContext.implicits._
val outlierDS = data.withColumn("weight", lit(10000.0)).as[Instance].flatMap {
val outlierDS = data.withColumn("weight", lit(1.0)).as[Instance].flatMap {
case Instance(l, w, f) =>
val outlierLabel = if (numClasses == 0) -l else numClasses - l - 1
List.fill(outlierRatio)(Instance(outlierLabel, 1.0, f)) ++ List(Instance(l, w, f))
List.fill(outlierRatio)(Instance(outlierLabel, 0.0001, f)) ++ List(Instance(l, w, f))
}
val trueModel = estimator.set(estimator.weightCol, "").fit(data)
val outlierModel = estimator.set(estimator.weightCol, "weight")
Expand Down