Skip to content

Spark 1095 : Adding explicit return types to all public methods #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NirmalReddy wants to merge 4 commits into from
Closed

Spark 1095 : Adding explicit return types to all public methods #168

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1c17773
fixed explicit types in core package
NirmalReddy Mar 18, 2014
02d0778
fixed explicit types in all the other packages
NirmalReddy Mar 18, 2014
8c5ff3e
Changed syntax of unit returning methods
NirmalReddy Mar 19, 2014
ac54b29
import misplaced
NirmalReddy Mar 26, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
import misplaced
  • Loading branch information
@NirmalReddy
NirmalReddy committed Mar 26, 2014
commit ac54b29e7a2db23b44c94e481cf9f94cdd22a8b3
4 changes: 2 additions & 2 deletions core/src/main/scala/org/apache/spark/deploy/master/ZooKeeperPersistenceEngine.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@ package org.apache.spark.deploy.master
import scala.collection.JavaConversions._

import akka.serialization.Serialization

import org.apache.curator.framework.CuratorFramework
Copy link
Contributor

@pwendell pwendell Mar 26, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These imports should be grouped above with the akka import.

https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide#SparkCodeStyleGuide-Imports

import org.apache.spark.{Logging, SparkConf}
import org.apache.zookeeper.CreateMode

import org.apache.spark.{Logging, SparkConf}

class ZooKeeperPersistenceEngine(serialization: Serialization, conf: SparkConf)
extends PersistenceEngine
with Logging
Expand Down