Skip to content

[SPARK-18874][SQL] First phase: Deferring the correlated predicate pull up to Optimizer phase #16954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dilipbiswal wants to merge 9 commits into from
Closed

[SPARK-18874][SQL] First phase: Deferring the correlated predicate pull up to Optimizer phase #16954

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
fdb8d2a
[SPARK-18874] First phase: Deferring the correlated predicate pull up…
dilipbiswal Feb 13, 2017
5f62a2c
Review comments
dilipbiswal Mar 1, 2017
8a8a7af
review comments
dilipbiswal Mar 1, 2017
f0d2e7f
Review comments
dilipbiswal Mar 2, 2017
55842fa
Review comment
dilipbiswal Mar 2, 2017
c677ed8
code review
dilipbiswal Mar 2, 2017
00c890e
Review comments
dilipbiswal Mar 5, 2017
27cb36a
rebase
dilipbiswal Mar 13, 2017
19cdbb0
Code review
dilipbiswal Mar 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rebase
  • Loading branch information
@dilipbiswal
dilipbiswal committed Mar 13, 2017
commit 27cb36a2ddfd13100348f8294155806b8f72fec3
4 changes: 0 additions & 4 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,10 +136,6 @@ trait CheckAnalysis extends PredicateHelper {
s"Scalar subquery must return only one column, but got ${query.output.size}")
}
else if (conditions.nonEmpty) {
} else if (conditions.nonEmpty) {
// Collect the columns from the subquery for further checking.
var subqueryColumns = conditions.flatMap(_.references).filter(query.output.contains)

def checkAggregate(agg: Aggregate): Unit = {
// Make sure correlated scalar subqueries contain one row for every outer row by
// enforcing that they are aggregates containing exactly one aggregate expression.
Expand Down