Skip to content

[SPARK-19281][PYTHON][ML] spark.ml Python API for FPGrowth #17218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zero323 wants to merge 22 commits into from
Closed

[SPARK-19281][PYTHON][ML] spark.ml Python API for FPGrowth #17218

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
e6935eb
Inital implementation
zero323 Mar 6, 2017
28d072b
Add docstring for FPGrowth and FPGrowthModel
zero323 Mar 10, 2017
a1920ab
Correct transform doctest to reflect SPARK-19940
zero323 Mar 14, 2017
d73f254
Move fpm specific Params from param.shared to fpm
zero323 Mar 16, 2017
5260497
Rename featuresCol to itemsCol (SPARK-19899)
zero323 Mar 16, 2017
feb6af9
Fix style
zero323 Mar 20, 2017
159f2ad
Add missing raise
zero323 Mar 23, 2017
154b5ba
Note that confidence is not used for fitting
zero323 Mar 23, 2017
df6777f
Remove dot from itemscol description
zero323 Mar 23, 2017
90918c5
Remove __init__ from HasItemsCol
zero323 Mar 23, 2017
43c9dcc
Add experimental notes
zero323 Mar 23, 2017
aa45479
Place docstring quotes in separate lines
zero323 Mar 23, 2017
d4ae39a
Add since import
zero323 Mar 23, 2017
6740581
Remove set spark.sql.shuffle.partition from FPGrowthTests
zero323 Mar 23, 2017
33c8971
Add super().setUp() in FPGrowthTests
zero323 Mar 23, 2017
eb4ec26
Sort imports in ml.tests
zero323 Mar 23, 2017
3c7f4f7
Copy Scala docs and add doc entry
zero323 Mar 23, 2017
3521d40
Add ml.fpm to sparktestsupport/modules
zero323 Mar 25, 2017
bdea0ff
Drop range tests and clean docstrings
zero323 Mar 26, 2017
deb2ce7
Move experimental annotation to the top of the docstrings
zero323 Mar 26, 2017
bf0a285
Fix getMinSupport
zero323 Mar 26, 2017
66b85e5
Remove 'single item' note from consequent description
zero323 Mar 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add missing raise
  • Loading branch information
@zero323
zero323 committed Mar 25, 2017
commit 159f2ad15c59150923507cfde19103a70ed8d0c5
8 changes: 4 additions & 4 deletions python/pyspark/ml/fpm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ def setMinSupport(self, value):
"""
Sets the value of :py:attr:`minSupport`.
"""
if not 0 <= value <= 1:
ValueError("Support must be in range [0, 1]")
if not (0 <= value <= 1):
raise ValueError("Support must be in range [0, 1]")
return self._set(minSupport=value)
Copy link
Member

@jkbradley jkbradley Mar 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removed too much! This line should remain


def getMinSupport(self):
Expand All @@ -65,8 +65,8 @@ def setMinConfidence(self, value):
"""
Sets the value of :py:attr:`minConfidence`.
"""
if not 0 <= value <= 1:
ValueError("Confidence must be in range [0, 1]")
if not (0 <= value <= 1):
raise ValueError("Confidence must be in range [0, 1]")
return self._set(minConfidence=value)

def getMinConfidence(self):
Expand Down