Skip to content

[SPARK-20172][Core] Add file permission check when listing files in FsHistoryProvider #17495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jerryshao wants to merge 7 commits into from
Closed

[SPARK-20172][Core] Add file permission check when listing files in FsHistoryProvider #17495

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
10d254b
Add file permission check in listing files
jerryshao Mar 31, 2017
63142cc
Also add logics to handle other exceptions
jerryshao Mar 31, 2017
1d1440b
Address the comments
jerryshao Apr 11, 2017
9447011
Further address the comments
jerryshao Apr 13, 2017
4d3838a
Address the comments to change the UT
jerryshao Apr 18, 2017
ab5117b
Using test UGI to mimic current user and groups
jerryshao Apr 19, 2017
b36fa75
Address the comments
jerryshao Apr 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Also add logics to handle other exceptions 
Change-Id: Ie2bd075561e481266dc8047e2af604f4d6c83810
  • Loading branch information
@jerryshao
jerryshao committed Mar 31, 2017
commit 63142cc82cc131b51c9d66525670caf4cba2ad39
4 changes: 4 additions & 0 deletions core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,6 +334,10 @@ private[history] class FsHistoryProvider(conf: SparkConf, clock: Clock)
// every poll.
logDebug(s"No permission to read $entry, ignoring.")
false

case e: Exception =>
logDebug(s"Fail to get status of $entry", e)
false
}
}
.flatMap { entry => Some(entry) }
Expand Down