Skip to content

[SPARK-20270][SQL] na.fill should not change the values in long or integer when the default value is in double #17577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dbtsai wants to merge 3 commits into from
+17 −2
Closed

[SPARK-20270][SQL] na.fill should not change the values in long or integer when the default value is in double #17577

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cb54407
na.fill will change the values in long or integer when the default va…
Apr 9, 2017
42c9eb0
Fix the test
Apr 9, 2017
3fb1a66
address feedback
Apr 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix the test
  • Loading branch information
DB Tsai committed Apr 9, 2017
commit 42c9eb0276ec46386d67dea7999d7796461de9da
2 changes: 1 addition & 1 deletion sql/core/src/test/scala/org/apache/spark/sql/DataFrameNaFunctionsSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ class DataFrameNaFunctionsSuite extends QueryTest with SharedSQLContext {
checkAnswer(
Seq[(java.lang.Long, java.lang.Double)]((null, 3.14), (9123146099426677101L, null),
(9123146560113991650L, 1.6), (null, null)).toDF("a", "b").na.fill(0.2),
Row(0, 3.14) :: Row(9123146099426677101L, 0.3) :: Row(9123146560113991650L, 1.6)
Row(0, 3.14) :: Row(9123146099426677101L, 0.2) :: Row(9123146560113991650L, 1.6)
:: Row(0, 0.2) :: Nil
)

Expand Down