Skip to content

[SPARK-2817] [SQL] add "show create table" support #1760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tianyi wants to merge 13 commits into from
Closed

[SPARK-2817] [SQL] add "show create table" support #1760

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
a03db77
[SPARK-2817] add "show create table" support
tianyi Aug 4, 2014
a337bd6
[SPARK-2817] add "show create table" support
tianyi Aug 4, 2014
bbf6b42
[SPARK-2817] add a systemProperties named "test.tmp.dir" to pass the …
tianyi Aug 5, 2014
bb82726
[SPARK-2817] remove test which requires a system from the whitelist.
tianyi Aug 5, 2014
bde800a
[SPARK-2817]
tianyi Aug 7, 2014
bfc2999
[SPARK-2817] add "File.separator" support, create a "testTmpDir" outs…
tianyi Aug 8, 2014
9f97586
[SPARK-2817] remove test.tmp.dir from pom.xml
Aug 8, 2014
9b2ba11
[SPARK-2817] fix the line length problem
Aug 8, 2014
dbe1031
[SPARK-2817] move some code out of function rewritePaths, as it may b…
Aug 8, 2014
60d48a9
[SPARK-2817] use system temporary folder instead of temporary files i…
tianyi Aug 12, 2014
565ec14
[SPARK-2817] fix the case problem
tianyi Aug 12, 2014
cbffe8b
[SPARK-2817] fix the case problem
tianyi Aug 12, 2014
7d28b15
[SPARK-2817] fix too short prefix problem
tianyi Aug 12, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[SPARK-2817] fix the line length problem
  • Loading branch information
tianyi committed Aug 8, 2014
commit 9b2ba1179c5dcc61d953dc26b544ced2c8c3786d
6 changes: 4 additions & 2 deletions sql/hive/src/main/scala/org/apache/spark/sql/hive/TestHive.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,12 @@ class TestHiveContext(sc: SparkContext) extends HiveContext(sc) {
set("hive.metastore.warehouse.dir", warehousePath)
}

val testTmpDir = if (System.getProperty("user.dir").endsWith("sql" + File.separator + "hive")) {
val testTmpDir = if (System.getProperty("user.dir").endsWith("sql" +
Copy link
Contributor

@marmbrus marmbrus Aug 11, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this just be:

val testTempDir = File.createtempfile("", "spark.hive.tmp")
testTempDir.delete()
testTempDir.mkdir()

I'm not sure why we would want to keep temporary files in the source tree instead of the system temporary folder.

File.separator + "hive")) {
new File(System.getProperty("user.dir") + File.separator + "tmp")
Copy link
Contributor

@chenghao-intel chenghao-intel Aug 8, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All we need is the temporal folder, not sure why we have to check the user working directory if end with sql/hive,
Can we just use val testTmpDir = new File(System.getProperty("user.dir") + File.separator + "tmp") instead?

Copy link
Contributor Author

@tianyi tianyi Aug 8, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chenghao-intel I did not understand why we have to check that too. I just follow the same way of handling "inRepoTests"

Copy link
Contributor

@marmbrus marmbrus Aug 8, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in repo tests is checking to see if the tests are there or if we should look for them in the hive distribution (they weren't always bundled with the source tree). If we need a temporary directory, we should use the mechanisms provided by the JVM for that (File.createTempFile)

} else {
new File(System.getProperty("user.dir") + File.separator + "sql" + File.separator + "hive" + File.separator + "tmp")
new File(System.getProperty("user.dir") + File.separator + "sql" +
File.separator + "hive" + File.separator + "tmp")
}

configure() // Must be called before initializing the catalog below.
Expand Down