Skip to content

[SPARK-20317] [REPL] Removing 'return' keyword in Scala method #17629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ouyangxiaochen wants to merge 1 commit into from
+4 −4
Closed

[SPARK-20317] [REPL] Removing 'return' keyword in Scala method #17629

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
use of the 'return' keyword is redundant.
  • Loading branch information
ouyangxiaochen committed Apr 13, 2017
commit 421709a9c38075e0fbe0c7865da76f8b308f2e82
8 changes: 4 additions & 4 deletions repl/src/main/scala/org/apache/spark/repl/ExecutorClassLoader.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ class ExecutorClassLoader(
ClassWriter.COMPUTE_FRAMES + ClassWriter.COMPUTE_MAXS)
val cleaner = new ConstructorCleaner(name, cw)
cr.accept(cleaner, 0)
return cw.toByteArray
cw.toByteArray
} else {
// Pass the class through unmodified
val bos = new ByteArrayOutputStream
Expand All @@ -208,7 +208,7 @@ class ExecutorClassLoader(
done = true
}
}
return bos.toByteArray
bos.toByteArray
}
}

Expand Down Expand Up @@ -238,9 +238,9 @@ extends ClassVisitor(ASM5, cv) {
mv.visitInsn(RETURN)
mv.visitMaxs(-1, -1) // stack size and local vars will be auto-computed
mv.visitEnd()
return null
null
} else {
return mv
mv
}
}
}