[SPARK-20421][core] Mark internal listeners as deprecated. #17766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These listeners weren't really meant for external consumption, but they're public and marked with @DeveloperAPI. Adding the deprecated tag warns people that they may soon go away (as they will as part of the work for SPARK-18085. Note that not all types made public by apache#648 are being deprecated. Some remaining types are still exposed through the SparkListener API. Also note the text for StorageStatus is a tiny bit different, since I'm not so sure I'll be able to remove it. But the effect for the users should be the same (they should stop trying to use it).
Contributor
Author
|
Test build #76154 has finished for PR 17766 at commit
|
Contributor
Author
|
Josh seems MIA, @srowen care to take a look? |
Contributor
|
Per my comments on the earlier email discussion thread, this seems fine to me. (I'm not totally MIA; I just got back from vacation and busy getting caught up). |
Contributor
Author
|
Thanks. Merging to master / 2.2. |
asfgit
pushed a commit
that referenced
this pull request
Apr 27, 2017
These listeners weren't really meant for external consumption, but they're public and marked with DeveloperApi. Adding the deprecated tag warns people that they may soon go away (as they will as part of the work for SPARK-18085). Note that not all types made public by #648 are being deprecated. Some remaining types are still exposed through the SparkListener API. Also note the text for StorageStatus is a tiny bit different, since I'm not so sure I'll be able to remove it. But the effect for the users should be the same (they should stop trying to use it). Author: Marcelo Vanzin <[email protected]> Closes #17766 from vanzin/SPARK-20421. (cherry picked from commit 561e9cc) Signed-off-by: Marcelo Vanzin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These listeners weren't really meant for external consumption, but they're
public and marked with @DeveloperAPI. Adding the deprecated tag warns people
that they may soon go away (as they will as part of the work for SPARK-18085).
Note that not all types made public by #648
are being deprecated. Some remaining types are still exposed through the
SparkListener API.
Also note the text for StorageStatus is a tiny bit different, since I'm not
so sure I'll be able to remove it. But the effect for the users should be the
same (they should stop trying to use it).