Skip to content

[SPARK-20465][CORE] Throws a proper exception when any temp directory could not be got #17768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HyukjinKwon wants to merge 6 commits into from
Closed

[SPARK-20465][CORE] Throws a proper exception when any temp directory could not be got #17768

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4500c2f
Throws a proper exception rather than ArrayIndexOutOfBoundsException …
HyukjinKwon Apr 26, 2017
b9ce248
Do not load default configuration to SparkConf
HyukjinKwon Apr 26, 2017
bf21e3b
Fix typos in path names
HyukjinKwon Apr 26, 2017
0f55c49
Address comment
HyukjinKwon Apr 26, 2017
b5c9839
Try with if-else
HyukjinKwon Apr 27, 2017
751f161
Clean up cached local dirs in tests
HyukjinKwon Apr 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Clean up cached local dirs in tests
  • Loading branch information
@HyukjinKwon
HyukjinKwon committed Apr 27, 2017
commit 751f161c292b364b3d6cc3fb270208c16662226c
5 changes: 1 addition & 4 deletions core/src/main/scala/org/apache/spark/util/Utils.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -740,10 +740,7 @@ private[spark] object Utils extends Logging {
* always return a single directory.
*/
def getLocalDir(conf: SparkConf): String = {
val localRootDirs = getOrCreateLocalRootDirs(conf)
if (localRootDirs.nonEmpty) {
localRootDirs(0)
} else {
getOrCreateLocalRootDirs(conf).headOption.getOrElse {
val configuredLocalDirs = getConfiguredLocalDirs(conf)
throw new IOException(
s"Failed to get a temp directory under [${configuredLocalDirs.mkString(",")}].")
Expand Down
4 changes: 4 additions & 0 deletions core/src/test/scala/org/apache/spark/storage/LocalDirsSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,10 @@ class LocalDirsSuite extends SparkFunSuite with BeforeAndAfter {
Utils.clearLocalRootDirs()
}

after {
Utils.clearLocalRootDirs()
}

test("Utils.getLocalDir() returns a valid directory, even if some local dirs are missing") {
// Regression test for SPARK-2974
assert(!new File("/NONEXISTENT_PATH").exists())
Expand Down