Skip to content

Conversation

@heary-cao
Copy link
Contributor

What changes were proposed in this pull request?

remove AggregateBenchmark testsuite warning:
such as '14:26:33.220 WARN org.apache.spark.sql.execution.aggregate.HashAggregateExec: Two level hashmap is disabled but vectorized hashmap is enabled.'

How was this patch tested?
unit tests: AggregateBenchmark
Modify the 'ignore function for 'test funtion

@heary-cao heary-cao changed the title Remove AggregateBenchmark testsuite warning: Two level hashmap is dis… [SPARK-20471]Remove AggregateBenchmark testsuite warning: Two level hashmap is dis… Apr 26, 2017
@hvanhovell
Copy link
Contributor

ok to test

@hvanhovell
Copy link
Contributor

This is kinda trivial, but sure.

@SparkQA
Copy link

SparkQA commented Apr 26, 2017

Test build #76188 has finished for PR 17771 at commit f77e582.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@heary-cao
Copy link
Contributor Author

@hvanhovell
thanks for review it.

Copy link
Member

@gatorsmile gatorsmile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gatorsmile
Copy link
Member

Could you update the PR title to

[SPARK-20471]Remove AggregateBenchmark testsuite warning: Two level hashmap is disabled but vectorized hashmap is enabled

@heary-cao heary-cao changed the title [SPARK-20471]Remove AggregateBenchmark testsuite warning: Two level hashmap is dis… [SPARK-20471]Remove AggregateBenchmark testsuite warning: Two level hashmap is disabled but vectorized hashmap is enabled Apr 28, 2017
@heary-cao
Copy link
Contributor Author

@gatorsmile
ok,
please review it again.
thanks.

@gatorsmile
Copy link
Member

Thanks! Merging to master/2.2

@asfgit asfgit closed this in ebff519 Apr 28, 2017
asfgit pushed a commit that referenced this pull request Apr 28, 2017
…hashmap is disabled but vectorized hashmap is enabled

What changes were proposed in this pull request?

remove  AggregateBenchmark testsuite warning:
such as '14:26:33.220 WARN org.apache.spark.sql.execution.aggregate.HashAggregateExec: Two level hashmap is disabled but vectorized hashmap is enabled.'

How was this patch tested?
unit tests: AggregateBenchmark
Modify the 'ignore function for 'test funtion

Author: caoxuewen <[email protected]>

Closes #17771 from heary-cao/AggregateBenchmark.

(cherry picked from commit ebff519)
Signed-off-by: gatorsmile <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants