Skip to content

[SPARK-20555][SQL] Fix mapping of Oracle DECIMAL types to Spark types #17830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gaborfeher wants to merge 3 commits into from
Closed

[SPARK-20555][SQL] Fix mapping of Oracle DECIMAL types to Spark types #17830

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2dadd29
Do not create custom catalyst types from Oracle decimal columns
Apr 28, 2017
9fad6eb
fix and add tests
Apr 28, 2017
3f841c7
comment nit
May 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Do not create custom catalyst types from Oracle decimal columns
  • Loading branch information
Gabor Feher committed Apr 28, 2017
commit 2dadd29b6713e9f19ce001614a30cfa9ff003f77
4 changes: 0 additions & 4 deletions sql/core/src/main/scala/org/apache/spark/sql/jdbc/OracleDialect.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,6 @@ private case object OracleDialect extends JdbcDialect {
// Not sure if there is a more robust way to identify the field as a float (or other
// numeric types that do not specify a scale.
case _ if scale == -127L => Option(DecimalType(DecimalType.MAX_PRECISION, 10))
case 1 => Option(BooleanType)
case 3 | 5 | 10 => Option(IntegerType)
case 19 if scale == 0L => Option(LongType)
case 19 if scale == 4L => Option(FloatType)
case _ => None
}
} else {
Expand Down