[SPARK-20621][deploy]Delete deprecated config parameter in 'spark-env.sh' #17881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hi @vanzin, just as talked, we should remote the |
srowen
approved these changes
May 6, 2017
Contributor
Author
|
Thanks @srowen. |
Member
|
Jenkins, ok to test |
|
Test build #76531 has finished for PR 17881 at commit
|
Contributor
|
Merging to master / 2.2. |
asfgit
pushed a commit
that referenced
this pull request
May 8, 2017
…v.sh' ## What changes were proposed in this pull request? Currently, `spark.executor.instances` is deprecated in `spark-env.sh`, because we suggest config it in `spark-defaults.conf` or other config file. And also this parameter is useless even if you set it in `spark-env.sh`, so remove it in this patch. ## How was this patch tested? Existing tests. Please review http://spark.apache.org/contributing.html before opening a pull request. Author: Xianyang Liu <[email protected]> Closes #17881 from ConeyLiu/deprecatedParam. (cherry picked from commit aeb2ecc) Signed-off-by: Marcelo Vanzin <[email protected]>
Contributor
Author
|
Thanks @vanzin . |
lycplus
pushed a commit
to lycplus/spark
that referenced
this pull request
May 24, 2017
…v.sh' ## What changes were proposed in this pull request? Currently, `spark.executor.instances` is deprecated in `spark-env.sh`, because we suggest config it in `spark-defaults.conf` or other config file. And also this parameter is useless even if you set it in `spark-env.sh`, so remove it in this patch. ## How was this patch tested? Existing tests. Please review http://spark.apache.org/contributing.html before opening a pull request. Author: Xianyang Liu <[email protected]> Closes apache#17881 from ConeyLiu/deprecatedParam.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently,
spark.executor.instancesis deprecated inspark-env.sh, because we suggest config it inspark-defaults.confor other config file. And also this parameter is useless even if you set it inspark-env.sh, so remove it in this patch.How was this patch tested?
Existing tests.
Please review http://spark.apache.org/contributing.html before opening a pull request.