Skip to content

[SPARK-20627][PYSPARK] Drop the hadoop distirbution name from the Python version #17885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
holdenk wants to merge 2 commits into from
Closed

[SPARK-20627][PYSPARK] Drop the hadoop distirbution name from the Python version #17885

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e30ba9
Drop the hadoop distirbution name from the Python version packaging s…
holdenk May 7, 2017
99414d7
Update comment since we don't have name
holdenk May 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update comment since we don't have name
  • Loading branch information
@holdenk
holdenk committed May 7, 2017
commit 99414d7ce352d7d4dd32a9ad4eda93c11d360cac
4 changes: 2 additions & 2 deletions dev/create-release/release-build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,8 +163,8 @@ if [[ "$1" == "package" ]]; then
export ZINC_PORT=$ZINC_PORT
echo "Creating distribution: $NAME ($FLAGS)"

# Write out the NAME and VERSION to PySpark version info we rewrite the - into a . and SNAPSHOT
# to dev0 to be closer to PEP440. We use the NAME as a "local version".
# Write out the VERSION to PySpark version info we rewrite the - into a . and SNAPSHOT
# to dev0 to be closer to PEP440.
PYSPARK_VERSION=`echo "$SPARK_VERSION" | sed -r "s/-/./" | sed -r "s/SNAPSHOT/dev0/"`
Copy link
Member

@srowen srowen May 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also affects the pyspark-*.tgz artifact name. It seems like this means the same file name will be used for different flavors of the release. If they're identical anyway it's just redundant, but are they? I don't know this part well so might be misunderstanding what this would do.

Copy link
Contributor Author

@holdenk holdenk May 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we currently only package Python for one Hadoop version. If we start doing multiple Hadoop versions for Python we can figure out how to handle that again.

echo "__version__='$PYSPARK_VERSION'" > python/pyspark/version.py

Expand Down