Skip to content

Conversation

@falaki
Copy link
Contributor

@falaki falaki commented May 8, 2017

What changes were proposed in this pull request?

Cleaning existing temp tables before running tableNames tests

How was this patch tested?

SparkR Unit tests

@yhuai
Copy link
Contributor

yhuai commented May 8, 2017

@felixcheung fyi. I think the main problem of this test is that it will be broken if tests executed before this one leak any table. I think this change makes sense. I will merge it once it passes jenkins.

@shivaram
Copy link
Contributor

shivaram commented May 8, 2017

LGTM. Thanks @falaki -- BTW is this a problem only on master or should we also backport this ?

@falaki
Copy link
Contributor Author

falaki commented May 8, 2017

@SparkQA
Copy link

SparkQA commented May 8, 2017

Test build #76592 has finished for PR 17903 at commit 7020372.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yhuai
Copy link
Contributor

yhuai commented May 8, 2017

Seems 2.2 build is fine. But, I'd like to get this merged in branch-2.2 since this test will fail if any previous tests leak tables.

@yhuai
Copy link
Contributor

yhuai commented May 8, 2017

Thanks @falaki. Merging to master and branch-2.2.

asfgit pushed a commit that referenced this pull request May 8, 2017
## What changes were proposed in this pull request?
Cleaning existing temp tables before running tableNames tests

## How was this patch tested?
SparkR Unit tests

Author: Hossein <[email protected]>

Closes #17903 from falaki/SPARK-20661.

(cherry picked from commit 2abfee1)
Signed-off-by: Yin Huai <[email protected]>
@asfgit asfgit closed this in 2abfee1 May 8, 2017
@felixcheung
Copy link
Member

felixcheung commented May 8, 2017 via email

@yhuai
Copy link
Contributor

yhuai commented May 8, 2017

I do not think #17649 caused the problem. I saw failures without that internally.

@felixcheung
Copy link
Member

felixcheung commented May 9, 2017

ah ok, i thought we said it was this build introducing this failure #17892 (comment) and #17903 (comment)

thanks, it's good to know

edit: looking into this, I'm not sure how this failure occurs - Perhaps it is picking up tables created in Scala test. I will follow up for more deterministic way to check this.

lycplus pushed a commit to lycplus/spark that referenced this pull request May 24, 2017
## What changes were proposed in this pull request?
Cleaning existing temp tables before running tableNames tests

## How was this patch tested?
SparkR Unit tests

Author: Hossein <[email protected]>

Closes apache#17903 from falaki/SPARK-20661.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants