[SPARK-20689][PYSPARK] python doctest leaking bucketed table #17932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #76730 has started for PR 17932 at commit |
Member
Author
|
Jenkins, retest this please |
gatorsmile
reviewed
May 10, 2017
| :py:meth:`DataFrameWriter.saveAsTable`. | ||
| >>> (df.write.format('parquet') | ||
| >>> (df.write.format('parquet') # doctest: +SKIP |
Member
There was a problem hiding this comment.
Glad to know it. : ) For multi-line commands, we just need to do it in the first line?
Member
Author
There was a problem hiding this comment.
only the line with >>>
|
Test build #76736 has finished for PR 17932 at commit
|
Member
|
LGTM as targeted. |
Member
|
LGTM |
Member
|
Thanks! Merging to master. |
|
Test build #76753 has finished for PR 17932 at commit
|
Member
|
I see I am the one to blame here. Sorry for that @felixcheung |
Member
|
@zero323 That is fine. I should find the issue when I reviewed it. |
lycplus
pushed a commit
to lycplus/spark
that referenced
this pull request
May 24, 2017
## What changes were proposed in this pull request? It turns out pyspark doctest is calling saveAsTable without ever dropping them. Since we have separate python tests for bucketed table, and there is no checking of results, there is really no need to run the doctest, other than leaving it as an example in the generated doc ## How was this patch tested? Jenkins Author: Felix Cheung <[email protected]> Closes apache#17932 from felixcheung/pytablecleanup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
It turns out pyspark doctest is calling saveAsTable without ever dropping them. Since we have separate python tests for bucketed table, and there is no checking of results, there is really no need to run the doctest, other than leaving it as an example in the generated doc
How was this patch tested?
Jenkins