Skip to content

[SPARK-2851] [mllib] DecisionTree Python consistency update #1798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jkbradley wants to merge 8 commits into from
Closed

[SPARK-2851] [mllib] DecisionTree Python consistency update #1798

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
eaf84c0
Added DecisionTree static train() methods API to match Python, but wi…
jkbradley Aug 5, 2014
c699850
a few doc comments
jkbradley Aug 5, 2014
e358661
DecisionTree API change:
jkbradley Aug 6, 2014
fe6dbfa
removed unnecessary imports
jkbradley Aug 6, 2014
00f820e
Merge remote-tracking branch 'upstream/master' into dt-python-consist…
jkbradley Aug 6, 2014
ee1d236
DecisionTree API updates:
jkbradley Aug 6, 2014
a0d7dbe
DecisionTree: In Java-friendly train* methods, changed to use JavaRDD…
jkbradley Aug 6, 2014
6f7edf8
Merge remote-tracking branch 'upstream/master' into dt-python-consist…
jkbradley Aug 6, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
a few doc comments
  • Loading branch information
@jkbradley
jkbradley committed Aug 5, 2014
commit c69985063c22b1802d7755bd6b12e1e8cd76ba74
3 changes: 3 additions & 0 deletions mllib/src/main/scala/org/apache/spark/mllib/tree/DecisionTree.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,7 @@ object DecisionTree extends Serializable with Logging {
new DecisionTree(strategy).train(input)
}

// Optional arguments in Python: maxBins
def train(
input: RDD[LabeledPoint],
algo: Algo,
Expand All @@ -309,6 +310,7 @@ object DecisionTree extends Serializable with Logging {
maxDepth: Int,
maxBins: Int): DecisionTreeModel = ???

// Optional arguments in Python: all but input, numClassesForClassification
def trainClassifier(
input: RDD[LabeledPoint],
Copy link
Contributor

@mengxr mengxr Aug 6, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RDD -> JavaRDD. Sorry I missed this in the first pass.

numClassesForClassification: Int,
Expand All @@ -317,6 +319,7 @@ object DecisionTree extends Serializable with Logging {
maxDepth: Int,
maxBins: Int): DecisionTreeModel = ???

// Optional arguments in Python: all but input
def trainRegressor(
input: RDD[LabeledPoint],
Copy link
Contributor

@mengxr mengxr Aug 6, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto: RDD -> JavaRDD.

categoricalFeaturesInfo: Map[Int,Int],
Expand Down