Skip to content

[SPARK-20887][CORE] support alternative keys in ConfigBuilder #18110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cloud-fan wants to merge 3 commits into from
Closed

[SPARK-20887][CORE] support alternative keys in ConfigBuilder #18110

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
200ee54
support alternative keys in ConfigBuilder
cloud-fan May 25, 2017
3f9d202
rename a config
cloud-fan May 25, 2017
a637e95
add comment
cloud-fan May 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add comment
  • Loading branch information
@cloud-fan
cloud-fan committed May 26, 2017
commit a637e95794c8d0db602c8b2d8c2a19250b058200
4 changes: 4 additions & 0 deletions core/src/main/scala/org/apache/spark/internal/config/ConfigReader.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,10 @@ private[spark] class ConfigReader(conf: ConfigProvider) {
}
}

/**
* Gets the value of a config from the given `ConfigProvider`. If no value is found for this
* config, and the `ConfigEntry` defines this config has default value, return the default value.
*/
private def getOrDefault(conf: ConfigProvider, key: String): Option[String] = {
Copy link
Contributor

@jiangxb1987 jiangxb1987 May 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add comment for this method.

conf.get(key).orElse {
ConfigEntry.findEntry(key) match {
Expand Down