Skip to content

SPARK-2893: Do not swallow Exceptions when running a custom kryo registrator #1827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GrahamDennis wants to merge 4 commits into from
Closed

SPARK-2893: Do not swallow Exceptions when running a custom kryo registrator #1827

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b59d2c2
SPARK-2893: Do not swallow Exceptions when running a custom spark.kry…
GrahamDennis Aug 8, 2014
f480d85
[SPARK-2893] Fix typo.
GrahamDennis Aug 14, 2014
65e53c5
[SPARK-2893]: Improve message when a spark.kryo.registrator fails.
GrahamDennis Aug 14, 2014
fbe4cb6
[SPARK-2878]: Update the test case to match the updated exception mes…
GrahamDennis Aug 14, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion core/src/main/scala/org/apache/spark/serializer/KryoSerializer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,8 @@ class KryoSerializer(conf: SparkConf)
reg.registerClasses(kryo)
}
} catch {
case e: Exception => logError("Failed to run spark.kryo.registrator", e)
case e: Exception => throw
Copy link
Contributor

@rxin rxin Aug 14, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you change this to

    // Allow the user to register their own classes by setting spark.kryo.registrator
    for (regCls <- registrator) {
      logDebug("Running user registrator: " + regCls)
      try {
        val reg = Class.forName(regCls, true, classLoader).newInstance()
          .asInstanceOf[KryoRegistrator]
        reg.registerClasses(kryo)
      } catch {
        case e: Exception => 
          throw new SparkException(s"Failed to invoke $regCls", e)
      }
    }

new SparkException("Failed to run spark.kryo.registrator", e)
}

// Register Chill's classes; we do this after our ranges and the user's own classes to let
Expand Down
10 changes: 10 additions & 0 deletions core/src/test/scala/org/apache/spark/serializer/KryoSerializerSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,16 @@ class KryoSerializerSuite extends FunSuite with SharedSparkContext {
.fold(new ClassWithoutNoArgConstructor(10))((t1, t2) => new ClassWithoutNoArgConstructor(t1.x + t2.x)).x
assert(10 + control.sum === result)
}

test("kryo with nonexistant custom registrator should fail") {
Copy link
Contributor

@rxin rxin Aug 14, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small typo : nonexistent

import org.apache.spark.{SparkConf, SparkException}

val conf = new SparkConf(false)
conf.set("spark.kryo.registrator", "this.class.does.not.exist")

val thrown = intercept[SparkException](new KryoSerializer(conf).newInstance())
assert(thrown.getMessage.contains("Failed to run spark.kryo.registrator"))
}
}

class KryoSerializerResizableOutputSuite extends FunSuite {
Expand Down