Skip to content

[SPARK-20555][SQL] Fix mapping of Oracle DECIMAL types to Spark types in read path #18408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gatorsmile wants to merge 4 commits into from
Closed

[SPARK-20555][SQL] Fix mapping of Oracle DECIMAL types to Spark types in read path #18408

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2dadd29
Do not create custom catalyst types from Oracle decimal columns
Apr 28, 2017
9fad6eb
fix and add tests
Apr 28, 2017
3f841c7
comment nit
May 2, 2017
d8d4fad
fix.
gatorsmile Jun 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
comment nit
  • Loading branch information
Gabor Feher committed May 2, 2017
commit 3f841c72b27cdee496ece39e17d4bb88dcf61714
2 changes: 1 addition & 1 deletion ...r-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleIntegrationSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ class OracleIntegrationSuite extends DockerJDBCIntegrationSuite with SharedSQLCo
val rows = df.collect()
assert(rows.size == 1)
val row = rows(0)
// The main point of the below lines is not to make sure that these Oracle types are
// The main point of the below assertions is not to make sure that these Oracle types are
// mapped to decimal types, but to make sure that the returned values are correct.
// A value > 1 from DECIMAL(1) is correct:
assert(row.getDecimal(0).compareTo(BigDecimal.valueOf(4)) == 0)
Expand Down