Skip to content
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove extra comments
  • Loading branch information
Michael Gummelt committed Jul 3, 2017
commit a9d8998595dbcd8933740ee9474d0d4a11b0ffe4
Original file line number Diff line number Diff line change
Expand Up @@ -510,7 +510,6 @@ class CoarseGrainedSchedulerBackend(

/**
* Request an additional number of executors from the cluster manager.
*
* @return whether the request is acknowledged.
*/
final override def requestExecutors(numAdditionalExecutors: Int): Boolean = {
Expand Down Expand Up @@ -545,7 +544,6 @@ class CoarseGrainedSchedulerBackend(
/**
* Update the cluster manager on our scheduling needs. Three bits of information are included
* to help it make decisions.
*
* @param numExecutors The total number of executors we'd like to have. The cluster manager
* shouldn't kill any running executor to reach this number, but,
* if all existing executors were to die, this is the number of executors
Expand Down Expand Up @@ -591,7 +589,6 @@ class CoarseGrainedSchedulerBackend(
* of requesting a delta of executors risks double counting new executors when there are
* insufficient resources to satisfy the first request. We make the assumption here that the
* cluster manager will eventually fulfill all requests when resources free up.
*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: leave these as they were.

* @return a future whose evaluation indicates whether the request is acknowledged.
*/
protected def doRequestTotalExecutors(requestedTotal: Int): Future[Boolean] =
Expand All @@ -603,7 +600,6 @@ class CoarseGrainedSchedulerBackend(
* When asking the executor to be replaced, the executor loss is considered a failure, and
* killed tasks that are running on the executor will count towards the failure limits. If no
* replacement is being requested, then the tasks will not count towards the limit.
*
* @param executorIds identifiers of executors to kill
* @param replace whether to replace the killed executors with new ones, default false
* @param force whether to force kill busy executors, default false
Expand Down Expand Up @@ -670,15 +666,13 @@ class CoarseGrainedSchedulerBackend(

/**
* Kill the given list of executors through the cluster manager.
*
* @return whether the kill request is acknowledged.
*/
protected def doKillExecutors(executorIds: Seq[String]): Future[Boolean] =
Future.successful(false)

/**
* Request that the cluster manager kill all executors on a given host.
*
* @return whether the kill request is acknowledged.
*/
final override def killExecutorsOnHost(host: String): Boolean = {
Expand Down