Skip to content

[SPARK-21306][ML] OneVsRest should support setWeightCol #18554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
facaiy wants to merge 16 commits into from
Closed

[SPARK-21306][ML] OneVsRest should support setWeightCol #18554

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
f178595
BUG: cache weightCol if necessary
facaiy Jul 6, 2017
a3e6e96
TST: add unit test
facaiy Jul 6, 2017
931d02d
TST: concise comment
facaiy Jul 6, 2017
25d681f
ENH: python, cache weightCol
facaiy Jul 7, 2017
c380ba7
BUG: check weightCol defined
facaiy Jul 7, 2017
e511b90
TST: model is not None
facaiy Jul 7, 2017
1c215f3
CLN: use if-indent style
facaiy Jul 7, 2017
2d3ce90
ENH: add weightCol
facaiy Jul 13, 2017
ea92228
TST: modify test case
facaiy Jul 13, 2017
57fc4b3
ENH: add weightCol for python part
facaiy Jul 13, 2017
00a7ed8
CLN: revise comment
facaiy Jul 13, 2017
a57f096
TST: python test for setWeightCol
facaiy Jul 13, 2017
54e0fca
DOC: add description
facaiy Jul 13, 2017
9ba0e2b
TST: classifier doesn't have weightCol
facaiy Jul 19, 2017
db303a0
CLN: mv weightCol to the end
facaiy Jul 26, 2017
8c0beba
TST: remove ovr2 nad ovr4
facaiy Jul 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
TST: python test for setWeightCol
  • Loading branch information
@facaiy
facaiy committed Jul 13, 2017
commit a57f096eb34e57d6a72221f29d84b5ef0c296b9b
7 changes: 4 additions & 3 deletions python/pyspark/ml/tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1255,15 +1255,16 @@ def test_output_columns(self):
output = model.transform(df)
self.assertEqual(output.columns, ["label", "features", "prediction"])

def test_cache_weightCol_if_necessary(self):
def test_support_for_weightCol(self):
Copy link
Contributor

@holdenk holdenk Jul 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to also test with a classifier that doesn't have a weight col?

Copy link
Contributor Author

@facaiy facaiy Jul 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Use DecisionTreeClassifier to test.

df = self.spark.createDataFrame([(0.0, Vectors.dense(1.0, 0.8), 1.0),
(1.0, Vectors.sparse(2, [], []), 1.0),
(2.0, Vectors.dense(0.5, 0.5), 1.0)],
["label", "features", "weight"])
lr = LogisticRegression(maxIter=5, regParam=0.01)
ovr = OneVsRest(classifier=lr, weightCol="weight")
model = ovr.fit(df)
self.assertIsNotNone(model)
self.assertIsNotNone(ovr.fit(df))
ovr2 = OneVsRest(classifier=lr).setWeightCol("weight")
Copy link
Contributor

@yanboliang yanboliang Jul 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: We can remove test of ovr2 and ovr4, setting param in different way will run the same code at backend.

Copy link
Contributor Author

@facaiy facaiy Jul 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cleaned.

self.assertIsNotNone(ovr2.fit(df))


class HashingTFTest(SparkSessionTestCase):
Expand Down