[SPARK-20566][SQL][BRANCH-2.2] ColumnVector should support appendFloats for array
#18557
Conversation
…ats` for array This PR aims to add a missing `appendFloats` API for array into **ColumnVector** class. For double type, there is `appendDoubles` for array [here](https://github.com/apache/spark/blob/master/sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVector.java#L818-L824). Pass the Jenkins with a newly added test case. Author: Dongjoon Hyun <[email protected]> Closes #17836 from dongjoon-hyun/SPARK-20566.
|
Test build #79306 has finished for PR 18557 at commit
|
|
Hi, @cloud-fan . |
|
@dongjoon-hyun Is there any reason to backport this to previous versions? This is because we had such a discussion. |
|
Hi, @kiszk . |
|
We have not seen any failure in test suites. And, there is no usage of this API in Spark 2.2. Does this missing cause any failure of test or application program? If so, it is good to put a sample program in this PR. |
|
I've changed the ticket type from |
|
I know that 'there is no usage of this API internally in Spark 2.2', but it's only for 2.2.0. Anyway, @cloud-fan changes the issue type. If that means backporting is not allowed for this patch, I have no objection for the community decision. I agree with that, too. So, @kiszk and @cloud-fan . Given that, may I close this PR? |
|
BTW, thank you for swift reviews and feedbacks on my PR. :) |
|
|
|
Yep. It's totally internal officially. What I meant with I'll close this PR. Thank you again. |
4 participants
What changes were proposed in this pull request?
This PR aims to add a missing
appendFloatsAPI for array into ColumnVector class. For double type, there isappendDoublesfor array here.How was this patch tested?
Pass the Jenkins with a newly added test case.