[SPARK-21374][CORE] Fix reading globbed paths from S3 into DF with disabled FS cache #18623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
ok to test |
|
Test build #79768 has finished for PR 18623 at commit
|
zsxwing
reviewed
Aug 3, 2017
| val fs = hdfsPath.getFileSystem(hadoopConf) | ||
| val qualified = hdfsPath.makeQualified(fs.getUri, fs.getWorkingDirectory) | ||
| SparkHadoopUtil.get.globPathIfNecessary(qualified) | ||
| SparkHadoopUtil.get.globPathIfNecessary(qualified, hadoopConf) |
Member
There was a problem hiding this comment.
Could you pass FileSystem into globPathIfNecessary?
asfgit
pushed a commit
that referenced
this pull request
Aug 7, 2017
…sabled FS cache This PR replaces #18623 to do some clean up. Closes #18623 Jenkins Author: Shixiong Zhu <[email protected]> Author: Andrey Taptunov <[email protected]> Closes #18848 from zsxwing/review-pr18623.
MatthewRBruce
pushed a commit
to Shopify/spark
that referenced
this pull request
Jul 31, 2018
…sabled FS cache This PR replaces apache#18623 to do some clean up. Closes apache#18623 Jenkins Author: Shixiong Zhu <[email protected]> Author: Andrey Taptunov <[email protected]> Closes apache#18848 from zsxwing/review-pr18623.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
SparkHadoopUtil.globPath method uses incorrect configuration to retrieve instance of org.apache.hadoop.fs.FileSystem.
Accidentally, this can work correctly for two reasons:
Therefore, incorrect configuration is omitted in SparkHadoopUtil.globPath and previously initialized instance of FileSystem is returned with correct configuration.
However, if filesystem caching is disabled (non-default behavior) incorrect configuration in SparkHadoopUtils.globPath is passed to org.apache.hadoop.fs.FileSystem.get() method what creates new instance of FileSystem with this incorrect configuration.
In this change two overloaded methods (globPath and globPathIfNecessary) are added to SparkHadoopUtil class which can receive up to date configuration from caller method. These two methods are used in DataSource class to read into DataFrame from globbed path.
How was this patch tested?
./dev/run-tests passed + example from SPARK-21374 was tested with patched jars.
@zsxwing @liancheng