Skip to content

[SPARK-21389][ML][MLLIB] Optimize ALS recommendForAll by gemm #18624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mpjlu wants to merge 9 commits into from
Closed

[SPARK-21389][ML][MLLIB] Optimize ALS recommendForAll by gemm #18624

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5ca3fd1
add poll for PriorityQueue
Jul 13, 2017
215efc3
test pass
Jul 13, 2017
7c587f4
fix bug
Jul 13, 2017
e8a40ed
code style change
Jul 13, 2017
963dae2
Code style fix
Jul 13, 2017
e5881f0
fix build error
Jul 14, 2017
4a9b350
fix DenseMatrix Store bugs
Jul 17, 2017
a5bf101
change poll to sortBy
Jul 17, 2017
f36706a
reset code
Dec 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
change poll to sortBy
  • Loading branch information
Peng Meng committed Jul 17, 2017
commit a5bf101f2db29e85d31e0a7ccf7b07e9b730455b
13 changes: 6 additions & 7 deletions mllib/src/main/scala/org/apache/spark/mllib/recommendation/MatrixFactorizationModel.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,16 +307,15 @@ object MatrixFactorizationModel extends Loader[MatrixFactorizationModel] {
pq += dstIds(k) -> ratings(i, k)
k += 1
}
var size = pq.size
while (size > 0) {
size -= 1
val factor = pq.poll()
dstIdMatrix(j + size) = factor._1
scoreMatrix(j + size) = factor._2
k = 0
pq.toArray.sortBy(-_._2).foreach { case (id, score) =>
dstIdMatrix(j + k) = id
scoreMatrix(j + k) = score
k += 1
}
i += 1
// pq.size maybe less than num, corner case
j += num
i += 1
pq.clear()
}
(index, (srcIds, dstIdMatrix, new DenseMatrix(m, num, scoreMatrix, true)))
Expand Down