Skip to content

Fix the simpleString used in error messages #18667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fxbonnet wants to merge 1 commit into from
Closed

Fix the simpleString used in error messages #18667

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sql/catalyst/src/main/scala/org/apache/spark/sql/types/LongType.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ class LongType private() extends IntegralType {
*/
override def defaultSize: Int = 8

override def simpleString: String = "bigint"
override def simpleString: String = "long"
Copy link
Member

@srowen srowen Jul 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so. bigint is the SQL type for an 8-byte integer, right?

Copy link
Author

@fxbonnet fxbonnet Jul 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you try to read a csv and map to a case class with a Long your get a message like this one:
EXCEPTION:org.apache.spark.sql.AnalysisException: Cannot up cast linked_docs.MR_NUMBER_OF_DOCS_UPLOADED from string to bigint as it may truncate
The type path of the target object is:

  • field (class: "scala.Long", name: "MR_NUMBER_OF_DOCS_UPLOADED")

Getting a message that talks about bigint while you are trying to cast a String to a Long looks confusing to me. I thought this was a typo.

Copy link
Member

@srowen srowen Jul 31, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're renaming the whole type, when the issue is at best that some intermediate stage of the plan does cast to bigint first. At the least, this is not the fix, and I'm not sure it's really a problem, even if the error is from an implementation detail.


private[spark] override def asNullable: LongType = this
}
Expand Down