Skip to content

[SPARK-21621][Core] Reset numRecordsWritten after DiskBlockObjectWriter.commitAndGet called #18830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ConeyLiu wants to merge 1 commit into from
Closed

[SPARK-21621][Core] Reset numRecordsWritten after DiskBlockObjectWriter.commitAndGet called #18830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions core/src/main/scala/org/apache/spark/storage/DiskBlockObjectWriter.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ private[spark] class DiskBlockObjectWriter(
/**
* Keep track of number of records written and also use this to periodically
* output bytes written since the latter is expensive to do for each record.
* And we reset it after every commitAndGet called.
*/
private var numRecordsWritten = 0

Expand Down Expand Up @@ -185,6 +186,7 @@ private[spark] class DiskBlockObjectWriter(
// In certain compression codecs, more bytes are written after streams are closed
writeMetrics.incBytesWritten(committedPosition - reportedPosition)
reportedPosition = committedPosition
numRecordsWritten = 0
fileSegment
} else {
new FileSegment(file, committedPosition, 0)
Expand Down
1 change: 1 addition & 0 deletions core/src/test/scala/org/apache/spark/storage/DiskBlockObjectWriterSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ class DiskBlockObjectWriterSuite extends SparkFunSuite with BeforeAndAfterEach {
writer.revertPartialWritesAndClose()
assert(firstSegment.length === file.length())
assert(writeMetrics.bytesWritten === file.length())
assert(writeMetrics.recordsWritten == 1)
}

test("calling revertPartialWritesAndClose() after commit() should have no effect") {
Expand Down