[SPARK-21565][SS] Propagate metadata in attribute replacement. #18840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
ok to test |
zsxwing
requested changes
Aug 4, 2017
| .outputMode("append") | ||
| .format("console") | ||
| .start() | ||
| q.processAllAvailable() |
Member
There was a problem hiding this comment.
nit: q.processAllAvailable() ->
try {
q.processAllAvailable()
} finally {
q.stop()
}
|
Test build #80233 has finished for PR 18840 at commit
|
Member
|
LGTM pending tests. |
Member
|
@Joseph-Torres could you change the PR title to "[SPARK-21565][SS] Propagate metadata in attribute replacement"? We usually put the module name in the PR title. |
jose-torres
changed the title
|
Test build #80356 has finished for PR 18840 at commit
|
Member
|
Thanks! Merging to master and branch-2.2. |
asfgit
pushed a commit
that referenced
this pull request
Aug 7, 2017
## What changes were proposed in this pull request? Propagate metadata in attribute replacement during streaming execution. This is necessary for EventTimeWatermarks consuming replaced attributes. ## How was this patch tested? new unit test, which was verified to fail before the fix Author: Jose Torres <[email protected]> Closes #18840 from joseph-torres/SPARK-21565. (cherry picked from commit cce25b3) Signed-off-by: Shixiong Zhu <[email protected]>
MatthewRBruce
pushed a commit
to Shopify/spark
that referenced
this pull request
Jul 31, 2018
## What changes were proposed in this pull request? Propagate metadata in attribute replacement during streaming execution. This is necessary for EventTimeWatermarks consuming replaced attributes. ## How was this patch tested? new unit test, which was verified to fail before the fix Author: Jose Torres <[email protected]> Closes apache#18840 from joseph-torres/SPARK-21565. (cherry picked from commit cce25b3) Signed-off-by: Shixiong Zhu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Propagate metadata in attribute replacement during streaming execution. This is necessary for EventTimeWatermarks consuming replaced attributes.
How was this patch tested?
new unit test, which was verified to fail before the fix