Skip to content

[SPARK-21654][SQL] Complement SQL predicates expression description #18869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
viirya wants to merge 8 commits into from
Closed

[SPARK-21654][SQL] Complement SQL predicates expression description #18869

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9895843
Complement SQL predicates document.
viirya Aug 7, 2017
1369fd5
More clear statement on binary comparison expressions. Add some test …
viirya Aug 9, 2017
bca2b0b
Adjust line break.
viirya Aug 9, 2017
b64c9e6
Remove unnecessary scalastyle off comments.
viirya Aug 9, 2017
d8f1479
Merge remote-tracking branch 'upstream/master' into SPARK-21654
viirya Sep 1, 2017
099c671
Note that only accept the type can be used for equality comparison in…
viirya Sep 1, 2017
444c64d
Improve test case for `In`.
viirya Sep 3, 2017
ec9199a
Add negative test for map type.
viirya Sep 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unnecessary scalastyle off comments.
  • Loading branch information
@viirya
viirya committed Aug 9, 2017
commit b64c9e67dfb34668ba93089d84f932778c005d7b
8 changes: 0 additions & 8 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,7 +611,6 @@ case class EqualNullSafe(left: Expression, right: Expression) extends BinaryComp
}
}

// scalastyle:off line.size.limit
@ExpressionDescription(
usage = "expr1 _FUNC_ expr2 - Returns true if `expr1` is less than `expr2`.",
arguments = """
Expand All @@ -632,7 +631,6 @@ case class EqualNullSafe(left: Expression, right: Expression) extends BinaryComp
> SELECT 1 _FUNC_ NULL;
NULL
""")
// scalastyle:on line.size.limit
case class LessThan(left: Expression, right: Expression)
extends BinaryComparison with NullIntolerant {

Expand All @@ -643,7 +641,6 @@ case class LessThan(left: Expression, right: Expression)
protected override def nullSafeEval(input1: Any, input2: Any): Any = ordering.lt(input1, input2)
}

// scalastyle:off line.size.limit
@ExpressionDescription(
usage = "expr1 _FUNC_ expr2 - Returns true if `expr1` is less than or equal to `expr2`.",
arguments = """
Expand All @@ -664,7 +661,6 @@ case class LessThan(left: Expression, right: Expression)
> SELECT 1 _FUNC_ NULL;
NULL
""")
// scalastyle:on line.size.limit
case class LessThanOrEqual(left: Expression, right: Expression)
extends BinaryComparison with NullIntolerant {

Expand All @@ -675,7 +671,6 @@ case class LessThanOrEqual(left: Expression, right: Expression)
protected override def nullSafeEval(input1: Any, input2: Any): Any = ordering.lteq(input1, input2)
}

// scalastyle:off line.size.limit
@ExpressionDescription(
usage = "expr1 _FUNC_ expr2 - Returns true if `expr1` is greater than `expr2`.",
arguments = """
Expand All @@ -696,7 +691,6 @@ case class LessThanOrEqual(left: Expression, right: Expression)
> SELECT 1 _FUNC_ NULL;
NULL
""")
// scalastyle:on line.size.limit
case class GreaterThan(left: Expression, right: Expression)
extends BinaryComparison with NullIntolerant {

Expand All @@ -707,7 +701,6 @@ case class GreaterThan(left: Expression, right: Expression)
protected override def nullSafeEval(input1: Any, input2: Any): Any = ordering.gt(input1, input2)
}

// scalastyle:off line.size.limit
@ExpressionDescription(
usage = "expr1 _FUNC_ expr2 - Returns true if `expr1` is greater than or equal to `expr2`.",
arguments = """
Expand All @@ -728,7 +721,6 @@ case class GreaterThan(left: Expression, right: Expression)
> SELECT 1 _FUNC_ NULL;
NULL
""")
// scalastyle:on line.size.limit
case class GreaterThanOrEqual(left: Expression, right: Expression)
extends BinaryComparison with NullIntolerant {

Expand Down