Skip to content

[SPARK-2970] [SQL] spark-sql script ends with IOException when EventLogging is enabled #1891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sarutak wants to merge 3 commits into from
Closed

[SPARK-2970] [SQL] spark-sql script ends with IOException when EventLogging is enabled #1891

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6c0997c
Modified the timing of shutdown hook execution. It should be executed…
sarutak Aug 11, 2014
8bd833c
Modified style
sarutak Aug 11, 2014
4a2d2fe
Modified comment style
sarutak Aug 11, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Modified the timing of shutdown hook execution. It should be executed… 
… before shutdown hook of o.a.h.f.FileSystem
  • Loading branch information
@sarutak
sarutak committed Aug 11, 2014
commit 6c0997c5c286d80503bbe1423902318571663365
7 changes: 5 additions & 2 deletions ...hriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ import jline.{ConsoleReader, History}
import org.apache.commons.lang.StringUtils
import org.apache.commons.logging.LogFactory
import org.apache.hadoop.conf.Configuration
import org.apache.hadoop.fs.FileSystem
import org.apache.hadoop.util.ShutdownHookManager
import org.apache.hadoop.hive.cli.{CliDriver, CliSessionState, OptionsProcessor}
import org.apache.hadoop.hive.common.LogUtils.LogInitializationException
import org.apache.hadoop.hive.common.{HiveInterruptCallback, HiveInterruptUtils, LogUtils}
Expand Down Expand Up @@ -116,13 +118,14 @@ private[hive] object SparkSQLCLIDriver {
SessionState.start(sessionState)

// Clean up after we exit
Runtime.getRuntime.addShutdownHook(
// This should be executed before shutdown hook of FileSystem to avoid race condition of FileSystem operation
ShutdownHookManager.get.addShutdownHook(
new Thread() {
override def run() {
SparkSQLEnv.stop()
}
}
)
, FileSystem.SHUTDOWN_HOOK_PRIORITY - 1)

// "-h" option has been passed, so connect to Hive thrift server.
if (sessionState.getHost != null) {
Expand Down