Skip to content

[SPARK-21677][SQL] json_tuple throws NullPointException when column is null as string type #18930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jmchung wants to merge 11 commits into from
Closed

[SPARK-21677][SQL] json_tuple throws NullPointException when column is null as string type #18930

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
596c280
fix null field name and add corresponding test
jmchung Aug 12, 2017
796041f
add description
jmchung Aug 12, 2017
f07a9f7
modify the comment about nullFieldName
jmchung Aug 13, 2017
ffa575a
make properly comment on pseudo field name
jmchung Aug 13, 2017
5d71263
discard fake field name, apply Option instead
jmchung Aug 14, 2017
0078445
added unit test that mixes constant field name and non constant one f…
jmchung Aug 15, 2017
5c69df5
use IndexedSeq instead of Array on foldableFieldNames to get better p…
jmchung Aug 15, 2017
ab16929
remove redundant comment and move toIndexedSeq after the map
jmchung Aug 15, 2017
e0e0c74
move test case from JsonSuite to JsonExpressionsSuite and add new tes…
jmchung Aug 16, 2017
5191ed4
consistent style in SQL and append the corresponding golden file of j…
jmchung Aug 17, 2017
ff3b9da
add a newline at the end and alter SQL
jmchung Aug 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add a newline at the end and alter SQL
  • Loading branch information
@jmchung
jmchung committed Aug 17, 2017
commit ff3b9daa0cb7d271872af914f5c5a6223f3c855c
6 changes: 3 additions & 3 deletions sql/core/src/test/resources/sql-tests/inputs/json-functions.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ select from_json('{"a":1}', 'a INT', map('mode', 1));
select from_json();
-- json_tuple
SELECT json_tuple('{"a" : 1, "b" : 2}', CAST(NULL AS STRING), 'b', CAST(NULL AS STRING), 'a');
CREATE TEMPORARY VIEW jsonTable(jsonField, a, b) AS SELECT * FROM VALUES ('{"a": 1, "b": 2}', 'a', 'b');
SELECT json_tuple(jsonField, b, CAST(NULL AS STRING), 'a') FROM jsonTable;
CREATE TEMPORARY VIEW jsonTable(jsonField, a) AS SELECT * FROM VALUES ('{"a": 1, "b": 2}', 'a');
SELECT json_tuple(jsonField, 'b', CAST(NULL AS STRING), a) FROM jsonTable;
-- Clean up
DROP VIEW IF EXISTS jsonTable;
DROP VIEW IF EXISTS jsonTable;
Copy link
Member

@gatorsmile gatorsmile Aug 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: just FYI, we do not need to drop the temp view in SQLQueryTestSuite.

Copy link
Member

@gatorsmile gatorsmile Aug 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a big deal. Thus, I will merge it when the test can pass.

4 changes: 2 additions & 2 deletions sql/core/src/test/resources/sql-tests/results/json-functions.sql.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,15 +189,15 @@ NULL 2 NULL 1


-- !query 18
CREATE TEMPORARY VIEW jsonTable(jsonField, a, b) AS SELECT * FROM VALUES ('{"a": 1, "b": 2}', 'a', 'b')
CREATE TEMPORARY VIEW jsonTable(jsonField, a) AS SELECT * FROM VALUES ('{"a": 1, "b": 2}', 'a')
-- !query 18 schema
struct<>
-- !query 18 output



-- !query 19
SELECT json_tuple(jsonField, b, CAST(NULL AS STRING), 'a') FROM jsonTable
SELECT json_tuple(jsonField, 'b', CAST(NULL AS STRING), a) FROM jsonTable
-- !query 19 schema
struct<c0:string,c1:string,c2:string>
-- !query 19 output
Expand Down