Skip to content

[SPARK-21726][SQL] Check for structural integrity of the plan in Optimzer in test mode. #18956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
viirya wants to merge 6 commits into from
Closed

[SPARK-21726][SQL] Check for structural integrity of the plan in Optimzer in test mode. #18956

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9170ceb
Check for structural integrity of the plan in Optimzer in test mode.
viirya Aug 16, 2017
c99011d
Address comment.
viirya Aug 16, 2017
0af1efb
Merge remote-tracking branch 'upstream/master' into SPARK-21726
viirya Aug 25, 2017
e1e4aa1
Merge remote-tracking branch 'upstream/master' into SPARK-21726
viirya Sep 6, 2017
959e315
We should analyze the plan for evaluating expression before optimizat…
viirya Sep 7, 2017
ecdfb7d
Address comments.
viirya Sep 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
We should analyze the plan for evaluating expression before optimizat… 
…ion.
  • Loading branch information
@viirya
viirya committed Sep 7, 2017
commit 959e31539f7e26d919617bb9969edec6e4daf2fd
6 changes: 4 additions & 2 deletions ...alyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import org.scalatest.prop.GeneratorDrivenPropertyChecks
import org.apache.spark.{SparkConf, SparkFunSuite}
import org.apache.spark.serializer.JavaSerializer
import org.apache.spark.sql.catalyst.{CatalystTypeConverters, InternalRow}
import org.apache.spark.sql.catalyst.analysis.ResolveTimeZone
import org.apache.spark.sql.catalyst.analysis.{ResolveTimeZone, SimpleAnalyzer}
import org.apache.spark.sql.catalyst.expressions.codegen._
import org.apache.spark.sql.catalyst.optimizer.SimpleTestOptimizer
import org.apache.spark.sql.catalyst.plans.logical.{OneRowRelation, Project}
Expand Down Expand Up @@ -188,7 +188,9 @@ trait ExpressionEvalHelper extends GeneratorDrivenPropertyChecks {
expected: Any,
inputRow: InternalRow = EmptyRow): Unit = {
val plan = Project(Alias(expression, s"Optimized($expression)")() :: Nil, OneRowRelation())
val optimizedPlan = SimpleTestOptimizer.execute(plan)
// We should analyze the plan first, otherwise we possibly optimize an unresolved plan.
val analyzedPlan = SimpleAnalyzer.execute(plan)
val optimizedPlan = SimpleTestOptimizer.execute(analyzedPlan)
checkEvaluationWithoutCodegen(optimizedPlan.expressions.head, expected, inputRow)
}

Expand Down