Skip to content

[SPARK-21779][PYTHON] Simpler DataFrame.sample API in Python #18999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HyukjinKwon wants to merge 4 commits into from
Closed

[SPARK-21779][PYTHON] Simpler DataFrame.sample API in Python #18999

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5de97d1
Simpler Dataset.sample API in Python
HyukjinKwon Aug 19, 2017
0328446
Add `[` and `]` to make no argument case pretty
HyukjinKwon Aug 20, 2017
24525bc
Move error validation tests to tests.py
HyukjinKwon Aug 21, 2017
f2608ab
No need to count in the tests.
HyukjinKwon Aug 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
No need to count in the tests.
  • Loading branch information
@HyukjinKwon
HyukjinKwon committed Aug 21, 2017
commit f2608ab0ca1e64ce97d65bffb62a07935e4b3db8
8 changes: 4 additions & 4 deletions python/pyspark/sql/tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2087,19 +2087,19 @@ def test_sample(self):
self.assertRaisesRegexp(
TypeError,
"should be a bool, float and number",
lambda: self.spark.range(1).sample().count())
lambda: self.spark.range(1).sample())

self.assertRaises(
TypeError,
lambda: self.spark.range(1).sample("a").count())
lambda: self.spark.range(1).sample("a"))

self.assertRaises(
TypeError,
lambda: self.spark.range(1).sample(seed="abc").count())
lambda: self.spark.range(1).sample(seed="abc"))

self.assertRaises(
IllegalArgumentException,
lambda: self.spark.range(1).sample(-1.0).count())
lambda: self.spark.range(1).sample(-1.0))

def test_toDF_with_schema_string(self):
data = [Row(key=i, value=str(i)) for i in range(100)]
Expand Down