[SPARK-21811][SQL]Inconsistency when finding the widest common type of a combination of DateType, StringType, and NumericType #19033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n a sequence of data types, the widest type is String
|
Can one of the admins verify this patch? |
jiangxb1987
reviewed
Feb 26, 2018
| } | ||
|
|
||
| private def findWiderCommonType(types: Seq[DataType]): Option[DataType] = { | ||
| var awaitingString = false |
Contributor
There was a problem hiding this comment.
Maybe we should make a pass of all dataTypes here, and see whether there exists StringType and all other dataTypes can be promoted to StringType, under that case we can default return StringType instead of None, WDYT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When finding the widest common type of a sequence of data types where the beginning of the sequence consists solely of DateType/Timestamp and Numeric types and the following data type in the sequence is a StringType, the widest common type becomes StringType (which was not the case prior, as an AnalysisException was raised).
How was this patch tested?
Added one test of Coalesce type coercion with the specific sequence of data types mentioned above and added onto a test of Union type coercion with a similar sequence of data types.
Please state that the contribution is your original work and that you license the work to the project under the project’s open source license.