Skip to content

Conversation

@iamhumanbeing
Copy link
Contributor

Signed-off-by: iamhumanbeing [email protected]

What changes were proposed in this pull request?

testNameNote = "(minNumPostShufflePartitions: 3) is not correct.
it should be "(minNumPostShufflePartitions: " + numPartitions + ")" in ExchangeCoordinatorSuite

How was this patch tested?

unit tests

Please review http://spark.apache.org/contributing.html before opening a pull request.

… in ExchangeCoordinatorSuite

Signed-off-by: iamhumanbeing <[email protected]>
@srowen
Copy link
Member

srowen commented Aug 26, 2017

Is this test failing for you?

@iamhumanbeing
Copy link
Contributor Author

@srowen : this test is not failing, but the test name is not correct. it should be "minNumPostShufflePartitions: 5", cause the unit test code set minNumPostShufflePartitions to 5, not 3.

determining the number of reducers: aggregate operator(minNumPostShufflePartitions: 3)
determining the number of reducers: join operator(minNumPostShufflePartitions: 3)
determining the number of reducers: complex query 1(minNumPostShufflePartitions: 3)
determining the number of reducers: complex query 2(minNumPostShufflePartitions: 3)

@SparkQA
Copy link

SparkQA commented Aug 26, 2017

Test build #3906 has finished for PR 19058 at commit 4e201e5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Aug 27, 2017

Merged to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants