Skip to content

Conversation

@gatorsmile
Copy link
Member

What changes were proposed in this pull request?

Creates SQLMetricsTestUtils for the utility functions of both Hive-specific and the other SQLMetrics test cases.

Also, move two SQLMetrics test cases from sql/hive to sql/core.

How was this patch tested?

N/A

@gatorsmile gatorsmile changed the title [SPARK-21878] [SQL] [TEST] Create SQLMetricsUtils [SPARK-21878] [SQL] [TEST] Create SQLMetricsTestUtils Aug 31, 2017
@gatorsmile
Copy link
Member Author

cc @cloud-fan

testMetricsNonDynamicPartition("parquet", "t1")
}

test("writing data out metrics with dynamic partition: parquet") {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The above two test cases are moved to sql/execution/metric/SQLMetricsSuite.scala

@SparkQA
Copy link

SparkQA commented Aug 31, 2017

Test build #81275 has finished for PR 19092 at commit 3dad127.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • class SQLMetricsSuite extends SparkFunSuite with SQLMetricsTestUtils with SharedSQLContext
  • trait SQLMetricsTestUtils extends SQLTestUtils
  • class SQLMetricsSuite extends SQLMetricsTestUtils with TestHiveSingleton

@gatorsmile
Copy link
Member Author

retest this please

@SparkQA
Copy link

SparkQA commented Aug 31, 2017

Test build #81276 has finished for PR 19092 at commit 3dad127.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • class SQLMetricsSuite extends SparkFunSuite with SQLMetricsTestUtils with SharedSQLContext
  • trait SQLMetricsTestUtils extends SQLTestUtils
  • class SQLMetricsSuite extends SQLMetricsTestUtils with TestHiveSingleton

@cloud-fan
Copy link
Contributor

LGTM

@gatorsmile
Copy link
Member Author

Thanks! Merging to master.

@asfgit asfgit closed this in 19b0240 Aug 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants