Skip to content

Conversation

@dorx
Copy link
Contributor

@dorx dorx commented Aug 12, 2014

For both Scala and Python.

The ser/de util functions were moved out of PythonMLLibAPI and into their own object to avoid creating the PythonMLLibAPI object inside of MultivariateStatisticalSummarySerialized, which is then referenced inside of a method in PythonMLLibAPI.

MultivariateStatisticalSummarySerialized was created to serialize the Vector fields in MultivariateStatisticalSummary.

@SparkQA
Copy link

SparkQA commented Aug 12, 2014

QA tests have started for PR 1911. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18392/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 12, 2014

QA results for PR 1911:
- This patch FAILED unit tests.
- This patch merges cleanly
- This patch adds the following public classes (experimental):
class MultivariateStatisticalSummarySerialized(val summary: MultivariateStatisticalSummary)
class MultivariateStatisticalSummary(object):

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18392/consoleFull

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DeveloperApi?

@SparkQA
Copy link

SparkQA commented Aug 13, 2014

QA tests have started for PR 1911. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18397/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 13, 2014

QA results for PR 1911:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds the following public classes (experimental):
class MultivariateStatisticalSummarySerialized(val summary: MultivariateStatisticalSummary)
class MultivariateStatisticalSummary(object):

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18397/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 13, 2014

QA tests have started for PR 1911. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18412/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 13, 2014

QA results for PR 1911:
- This patch FAILED unit tests.
- This patch merges cleanly
- This patch adds the following public classes (experimental):
class MultivariateStatisticalSummarySerialized(val summary: MultivariateStatisticalSummary)
class MultivariateStatisticalSummary(object):

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18412/consoleFull

@dorx
Copy link
Contributor Author

dorx commented Aug 13, 2014

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Aug 13, 2014

QA tests have started for PR 1911. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18414/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 13, 2014

QA results for PR 1911:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds the following public classes (experimental):
class MultivariateStatisticalSummarySerialized(val summary: MultivariateStatisticalSummary)
class MultivariateStatisticalSummary(object):

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18414/consoleFull

@mengxr
Copy link
Contributor

mengxr commented Aug 13, 2014

LGTM. Merged into both master and branch-1.1. Thanks for adding this and cleaning MLLibPythonAPI!!

@asfgit asfgit closed this in fe47359 Aug 13, 2014
asfgit pushed a commit that referenced this pull request Aug 13, 2014
…Summary) in Statistics

For both Scala and Python.

The ser/de util functions were moved out of `PythonMLLibAPI` and into their own object to avoid creating the `PythonMLLibAPI` object inside of `MultivariateStatisticalSummarySerialized`, which is then referenced inside of a method in `PythonMLLibAPI`.

`MultivariateStatisticalSummarySerialized` was created to serialize the `Vector` fields in `MultivariateStatisticalSummary`.

Author: Doris Xin <[email protected]>

Closes #1911 from dorx/colStats and squashes the following commits:

77b9924 [Doris Xin] developerAPI tag
de9cbbe [Doris Xin] reviewer comments and moved more ser/de
459faba [Doris Xin] colStats in Statistics for both Scala and Python

(cherry picked from commit fe47359)
Signed-off-by: Xiangrui Meng <[email protected]>
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
…Summary) in Statistics

For both Scala and Python.

The ser/de util functions were moved out of `PythonMLLibAPI` and into their own object to avoid creating the `PythonMLLibAPI` object inside of `MultivariateStatisticalSummarySerialized`, which is then referenced inside of a method in `PythonMLLibAPI`.

`MultivariateStatisticalSummarySerialized` was created to serialize the `Vector` fields in `MultivariateStatisticalSummary`.

Author: Doris Xin <[email protected]>

Closes apache#1911 from dorx/colStats and squashes the following commits:

77b9924 [Doris Xin] developerAPI tag
de9cbbe [Doris Xin] reviewer comments and moved more ser/de
459faba [Doris Xin] colStats in Statistics for both Scala and Python
snmvaughan pushed a commit to snmvaughan/spark that referenced this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants