Skip to content

[SPARK-21904] [SQL] Rename tempTables to tempViews in SessionCatalog #19117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gatorsmile wants to merge 4 commits into from
Closed

[SPARK-21904] [SQL] Rename tempTables to tempViews in SessionCatalog #19117

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
02815e7
rename temp tables to temp views.
gatorsmile Sep 4, 2017
595e502
fix.
gatorsmile Sep 5, 2017
a5bcc76
Merge remote-tracking branch 'upstream/master' into renameTempTablesT…
gatorsmile Sep 29, 2017
cfa0782
fix
gatorsmile Sep 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix
  • Loading branch information
@gatorsmile
gatorsmile committed Sep 29, 2017
commit cfa078260964b3baf782d9cdab3e967f5243ba10
2 changes: 1 addition & 1 deletion sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ object SessionCatalog {
/**
* An internal catalog that is used by a Spark Session. This internal catalog serves as a
* proxy to the underlying metastore (e.g. Hive Metastore) and it also manages temporary
* tables and functions of the Spark Session that it belongs to.
* views and functions of the Spark Session that it belongs to.
*
* This class must be thread-safe.
*/
Expand Down
6 changes: 3 additions & 3 deletions sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -795,7 +795,7 @@ abstract class DDLSuite extends QueryTest with SQLTestUtils {
checkAnswer(spark.table("teachers"), df)
}

test("rename temporary table - destination table with database name") {
test("rename temporary view - destination table with database name") {
withTempView("tab1") {
sql(
"""
Expand All @@ -820,7 +820,7 @@ abstract class DDLSuite extends QueryTest with SQLTestUtils {
}
}

test("rename temporary table") {
test("rename temporary view") {
withTempView("tab1", "tab2") {
spark.range(10).createOrReplaceTempView("tab1")
sql("ALTER TABLE tab1 RENAME TO tab2")
Expand All @@ -832,7 +832,7 @@ abstract class DDLSuite extends QueryTest with SQLTestUtils {
}
}

test("rename temporary table - destination table already exists") {
test("rename temporary view - destination table already exists") {
withTempView("tab1", "tab2") {
sql(
"""
Expand Down