Skip to content

[SPARK-21902][CORE] Print root cause for BlockManager#doPut #19171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
caneGuy wants to merge 3 commits into from
Closed

[SPARK-21902][CORE] Print root cause for BlockManager#doPut #19171

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
00fb077
[SPARK-21902][CORE] Print root cause for BlockManager#doPut
caneGuy Sep 9, 2017
86525f7
Remove duplicate logging
caneGuy Sep 9, 2017
a3ed8b3
Use NonFatal instead of Throwable
caneGuy Sep 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions core/src/main/scala/org/apache/spark/storage/BlockManager.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -988,6 +988,12 @@ private[spark] class BlockManager(
logWarning(s"Putting block $blockId failed")
}
res
} catch {
// Since removeBlockInternal may throw exception,
// we should print exception first to show root cause.
case e: Throwable =>
logWarning(s"Putting block $blockId failed due to exception $e.")
Copy link
Member

@kiszk kiszk Sep 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will we see the message Putting block $blockId failed due to exception twice in a log file?

Copy link
Contributor Author

@caneGuy caneGuy Sep 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update

Copy link
Contributor

@jerryshao jerryshao Sep 15, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please change to case NonFatal(e) =>?

Copy link
Contributor Author

@caneGuy caneGuy Sep 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done @jerryshao

throw e
} finally {
// This cleanup is performed in a finally block rather than a `catch` to avoid having to
// catch and properly re-throw InterruptedException.
Expand Down