Skip to content

[SPARK-21973][SQL] Add an new option to filter queries in TPC-DS #19188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maropu wants to merge 3 commits into from
Closed

[SPARK-21973][SQL] Add an new option to filter queries in TPC-DS #19188

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be1a199
Add a new option to filter queries
maropu Sep 13, 2017
cc11163
Fix
maropu Sep 13, 2017
b543e71
case-insensitive option matches
maropu Sep 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
case-insensitive option matches
  • Loading branch information
@maropu
maropu committed Sep 14, 2017
commit b543e710dae79da33a9334d5bbe4bb474a44b39c
10 changes: 7 additions & 3 deletions ...rc/test/scala/org/apache/spark/sql/execution/benchmark/TPCDSQueryBenchmarkArguments.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,16 +27,20 @@ class TPCDSQueryBenchmarkArguments(val args: Array[String]) {
parseArgs(args.toList)
validateArguments()

private def optionMatch(optionName: String, s: String): Boolean = {
optionName == s.toLowerCase(Locale.ROOT)
}

private def parseArgs(inputArgs: List[String]): Unit = {
var args = inputArgs

while(args.nonEmpty) {
while (args.nonEmpty) {
args match {
case ("--data-location") :: value :: tail =>
case optName :: value :: tail if optionMatch("--data-location", optName) =>
dataLocation = value
args = tail

case ("--query-filter") :: value :: tail =>
case optName :: value :: tail if optionMatch("--query-filter", optName) =>
queryFilter = value.toLowerCase(Locale.ROOT).split(",").map(_.trim).toSet
Copy link
Member

@gatorsmile gatorsmile Sep 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also make "--data-location" case insensitive?

Copy link
Member Author

@maropu maropu Sep 13, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

args = tail

Expand Down