Skip to content

[MINOR][DOC] Add missing call of update() in examples of PeriodicGraphCheckpointer & PeriodicRDDCheckpointer #19198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zhengruifeng wants to merge 1 commit into from
Closed

[MINOR][DOC] Add missing call of update() in examples of PeriodicGraphCheckpointer & PeriodicRDDCheckpointer #19198

zhengruifeng wants to merge 1 commit into from

Conversation

@zhengruifeng
Copy link
Contributor

@zhengruifeng zhengruifeng commented Sep 12, 2017

What changes were proposed in this pull request?

forgot to call update() with graph1 & rdd1 in examples for PeriodicGraphCheckpointer & PeriodicRDDCheckpoin

How was this patch tested?

existing tests

@SparkQA
Copy link

SparkQA commented Sep 12, 2017

Test build #81659 has finished for PR 19198 at commit 6f3859c.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@zhengruifeng
Copy link
Contributor Author

zhengruifeng commented Sep 12, 2017

retest this please

@SparkQA
Copy link

SparkQA commented Sep 12, 2017

Test build #81663 has finished for PR 19198 at commit 6f3859c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

WeichenXu123
WeichenXu123 approved these changes Sep 14, 2017
View reviewed changes
Copy link
Contributor

@WeichenXu123 WeichenXu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@asfgit asfgit closed this in 66cb72d Sep 14, 2017
@zhengruifeng zhengruifeng deleted the fix_doc_checkpointer branch September 14, 2017 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WeichenXu123 WeichenXu123 WeichenXu123 approved these changes

+1 more reviewer

@yanboliang yanboliang yanboliang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zhengruifeng @SparkQA @yanboliang @WeichenXu123