[SPARK-17642] [SQL] [FOLLOWUP] drop test tables and improve comments #19213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @cloud-fan |
|
Test build #81698 has finished for PR 19213 at commit
|
Contributor
|
LGTM, please also address one more comment that drop testing tables. |
wzhfy
changed the title
|
Test build #81747 has finished for PR 19213 at commit
|
cloud-fan
reviewed
Sep 14, 2017
| -- Describe a non-existent column | ||
| DESC desc_col_temp_table key1; | ||
|
|
||
| DROP VIEW desc_col_temp_table; |
Contributor
There was a problem hiding this comment.
since it's a view, can we name it desc_col_temp_view?
Contributor
There was a problem hiding this comment.
and it's better to put all DROP commands at the end.
Contributor
Author
There was a problem hiding this comment.
ok. I'll fix it right now.
|
Test build #81774 has finished for PR 19213 at commit
|
Contributor
|
thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Drop test tables and improve comments.
How was this patch tested?
Modified existing test.